Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gl2ps: init at 1.4.0 #64539

Merged
merged 1 commit into from Jul 21, 2019
Merged

gl2ps: init at 1.4.0 #64539

merged 1 commit into from Jul 21, 2019

Conversation

twhitehead
Copy link
Contributor

Motivation for this change

Library required by octave to close #38459. Picked @7c6f434c as maintainer as is the maintainer of octave. Hope this was okay.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from 7c6f434c July 9, 2019 19:01
risicle
risicle approved these changes Jul 9, 2019
View reviewed changes
Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds for me, non-nixos linux x86_64

@7c6f434c
Copy link
Member

I am OK with being listed as co-maintainer, but please also add yourself as a maintainer.

7c6f434c
7c6f434c approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@7c6f434c 7c6f434c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo maintainers expansion

@twhitehead
Copy link
Contributor Author

Should be good now (force pushed the addition of myself to maintainers and and co-maintainer on this package). Thanks!

@ofborg ofborg bot requested a review from 7c6f434c July 19, 2019 15:33
@7c6f434c 7c6f434c merged commit 1368f4b into NixOS:master Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle approved these changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

octave: abort when printing figure to pdf
3 participants
@twhitehead @7c6f434c @risicle