Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mirrors.nix: add alsa-project.org for alsa #64541

Merged
merged 1 commit into from Jul 11, 2019
Merged

mirrors.nix: add alsa-project.org for alsa #64541

merged 1 commit into from Jul 11, 2019

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Jul 9, 2019 •
edited

Motivation for this change

Aside from being an HTTPS endpoint, this is the canonical mirror for alsa
project downloads.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
mirrors.nix: add alsa-project.org for alsa
14a7161 
Aside from being an HTTPS endpoint, this is the canonical mirror for alsa
project downloads.
bhipple
bhipple commented Jul 9, 2019
View reviewed changes
pkgs/build-support/fetchurl/mirrors.nix
ftp://ftp.alsa-project.org/pub/
http://alsa.cybermirror.org/
http://www.mirrorservice.org/sites/ftp.alsa-project.org/pub/
http://alsa.mirror.fr/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other lines are changed because I fixed the 3-space indent to match the 2-space indent used elsewhere in this file.

@worldofpeace worldofpeace merged commit c0a0c1e into NixOS:master Jul 11, 2019
@worldofpeace
Copy link
Contributor

Thanks @bhipple

@bhipple bhipple deleted the mirrors/alsa branch July 16, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: fetch 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bhipple @worldofpeace