fzf: 0.17.5 -> 0.18.0 #64590
Merged
fzf: 0.17.5 -> 0.18.0 #64590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
approved these changes
Jul 10, 2019
There was a problem hiding this comment.
nix-review pr 64590 passes on NixOS
diff LGTM
binaries work
however, the vim plugin is now part of the base fzf package, this looks to be desired from the diff and the previous version was just skipping it.
Tree diffs
[nix-shell:~/.cache/nix-review/pr-64590-1]$ tree results/fzf/
results/fzf/
├── bin
│ ├── fzf
│ ├── fzf-share
│ └── fzf-tmux
└── share
├── fish
│ ├── vendor_conf.d
│ │ └── load-fzf-key-bindings.fish
│ └── vendor_functions.d
│ └── fzf_key_bindings.fish
├── fzf
│ ├── completion.bash
│ ├── completion.zsh
│ ├── key-bindings.bash
│ ├── key-bindings.fish
│ └── key-bindings.zsh
└── vim-plugins
└── fzf-0.18.0
└── plugin
└── fzf.vim
[13:23:20] jon@jon-workstation ~/projects/nixpkgs (master)
$ tree /nix/store/pwrpkfhv2xkrp3f9viffz3j44ajr71i3-fzf-0.17.5-bin
/nix/store/pwrpkfhv2xkrp3f9viffz3j44ajr71i3-fzf-0.17.5-bin
├── bin
│ ├── fzf
│ ├── fzf-share
│ └── fzf-tmux
└── share
├── fish
│ ├── vendor_conf.d
│ │ └── load-fzf-key-bindings.fish
│ └── vendor_functions.d
│ └── fzf_key_bindings.fish
└── fzf
├── completion.bash
├── completion.zsh
├── key-bindings.bash
├── key-bindings.fish
└── key-bindings.zsh
6 directories, 10 files
https://github.com/NixOS/nixpkgs/pull/64590
3 package were build:
fzf vimPlugins.fzfWrapper xmloscopy
|
@GrahamcOfBorg build fzf Just testing the darwin build |
|
Thanks @xrelkd and @jonringer 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update
fzfto the latest release.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)