Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitlbee-mastodon: init at 1.4.2 #64584

Merged
merged 1 commit into from Aug 8, 2019
Merged

bitlbee-mastodon: init at 1.4.2 #64584

merged 1 commit into from Aug 8, 2019

Conversation

jpotier
Copy link
Contributor

@jpotier jpotier commented Jul 10, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • (NA) Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • (NA) Tested execution of all binary files (usually in ./result/bin/)
  • (NA) Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jb55
Copy link
Contributor

jb55 commented Jul 10, 2019

another dejavu moment when I'm about to package something but I check here first. nixpkgs is becoming hive-mind like. Testing now.

@jpotier jpotier changed the title bitlbee-mastodon: init at v1.4.2 bitlbee-mastodon: init at 1.4.2 Jul 10, 2019
@jpotier
Copy link
Contributor Author

jpotier commented Jul 27, 2019

Should I pick reviewers/approvers manually in order to move this forward?

@jb55
Copy link
Contributor

jb55 commented Jul 27, 2019

fwiw I've been using this for the past 17 days without any issues.

@chreekat
Copy link
Contributor

chreekat commented Aug 1, 2019

This is implemented exactly the same as the other bitlbee plugins, lgtm

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/36

aanderse
aanderse requested changes Aug 7, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 very minor nitpicks, but yeah this should be merged. 👍

pkgs/applications/networking/instant-messengers/bitlbee-mastodon/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/instant-messengers/bitlbee-mastodon/default.nix Outdated Show resolved Hide resolved
@aanderse
Copy link
Member

aanderse commented Aug 7, 2019

@GrahamcOfBorg build bitlbee-mastodon

@aanderse aanderse merged commit c64106f into NixOS:master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jb55 jb55 jb55 approved these changes

@Lassulus Lassulus Lassulus approved these changes

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jpotier @jb55 @chreekat @nixos-discourse @aanderse @Lassulus