Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openmw-tes3mp: 0.7.0-alpha -> 2019-06-09 #64587

Closed
wants to merge 1 commit into from
Closed

openmw-tes3mp: 0.7.0-alpha -> 2019-06-09 #64587

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 10, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link
Author

ghost commented Jul 10, 2019

cc @abbradar

abbradar
abbradar reviewed Jul 18, 2019
View reviewed changes
Copy link
Member

@abbradar abbradar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's document update process more; other than that, nice work!

pkgs/games/openmw/tes3mp.nix Outdated Show resolved Hide resolved
pkgs/games/openmw/tes3mp.nix Show resolved Hide resolved
pkgs/games/openmw/tes3mp.nix Show resolved Hide resolved
pkgs/games/openmw/tes3mp.nix Show resolved Hide resolved
pkgs/games/openmw/tes3mp.nix Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Jul 18, 2019

@abbradar

Let's document update process more; other than that, nice work!

Basically I've stopped to build with tes3mp-deploy.sh and that made expression simpler. Also installation is now made by official cmake scripts

@abbradar abbradar closed this in 32e72ad Jul 20, 2019
@ghost
Copy link
Author

ghost commented Jul 20, 2019

@abbradar Thank you!

@ghost ghost deleted the openmw-tes3mp branch July 20, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@abbradar