Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kak-lsp: init at 6.2.1 #64617

Merged
merged 1 commit into from Jul 23, 2019
Merged

kak-lsp: init at 6.2.1 #64617

merged 1 commit into from Jul 23, 2019

Conversation

spacekookie
Copy link
Member

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Jul 11, 2019

@GrahamcOfBorg eval

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build kak-lsp

@worldofpeace
Copy link
Contributor

Hi @spacekookie. This expression looks good, could you give some pointers on how I should test its function?

@risicle
Copy link
Contributor

risicle commented Jul 14, 2019

To get this building on darwin you just have to add

  buildInputs = lib.optional stdenv.isDarwin [ darwin.apple_sdk.frameworks.Security ];

obviously having added darwin and stdenv to your args...

@spacekookie
Copy link
Member Author

spacekookie commented Jul 14, 2019 via email

@spacekookie
Copy link
Member Author

@risicle Ah nice, thank you for that tip! I just adjusted the derivation

@@ -0,0 +1,25 @@
{ lib, fetchFromGitHub, rustPlatform }:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ lib, fetchFromGitHub, rustPlatform }:
{stdenv, lib, fetchFromGitHub, rustPlatform }:

fix eval

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks! Completely missed that 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops we need darwin too

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build kak-lsp

@worldofpeace worldofpeace merged commit 837e696 into NixOS:master Jul 23, 2019
@worldofpeace
Copy link
Contributor

Thanks @spacekookie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants