Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make-tarball / lib-tests: reduce duplication #64563

Merged
merged 1 commit into from Jul 11, 2019
Merged

make-tarball / lib-tests: reduce duplication #64563

merged 1 commit into from Jul 11, 2019

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Jul 10, 2019 •
edited

The misc.nix and systems.nix tests were invoked at three different
places. Let's not that.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
make-tarball / lib-tests: reduce duplication
06b356e 
The misc.nix and systems.nix tests were invoked at three different
places. Let's not that.
@FRidh FRidh requested review from edolstra and nbp as code owners July 10, 2019 10:42
@FRidh FRidh merged commit 8931db9 into NixOS:master Jul 11, 2019
@FRidh FRidh deleted the tarball branch July 11, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@FRidh