Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fasttext: 0.2.0 -> 0.9.1 #64639

Merged
merged 1 commit into from Jul 12, 2019
Merged

fasttext: 0.2.0 -> 0.9.1 #64639

merged 1 commit into from Jul 12, 2019

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Changes:

  • Refactoring of internal classes.
  • Better unicode handling.

https://github.com/facebookresearch/fastText/releases/tag/v0.9.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
fasttext: 0.2.0 -> 0.9.1
a185853 
Changes:

- Refactoring of internal classes.
- Better unicode handling.

https://github.com/facebookresearch/fastText/releases/tag/v0.9.1
@danieldk
Copy link
Contributor Author

@GrahamcOfBorg build fasttext

jonringer
jonringer reviewed Jul 11, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this looks like a repeat of your library, I think you could use toPythonApplication from the other derivation.

in pkgs/top-level/all-packages.nix

fasttext = callPackage ../applications/science/machine-learning/fasttext { };

to

fasttext = python3.pkgs.toPythonApplication python3.pkgs.fasttext;

or something similar, i might be off by a little in terms of syntax.

EDIT:
nevermind, looked at the file. They are in the same repo, but they are completely different builds.

jonringer
jonringer approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review pr 64639 passes on NixOS
diff LGTM
binary works

$ nix path-info -Sh ./results/fasttext
/nix/store/a3n85z82jl2mxskd73gv6ky9w7s5qxgr-fasttext-0.9.1        34.1M

@teto
Copy link
Member

teto commented Jul 12, 2019

Thanks for the package and to @jonringer for his reviews <3

@teto teto merged commit 3a4ba91 into NixOS:master Jul 12, 2019
@danieldk danieldk deleted the fasttext-0.9.1 branch August 17, 2020 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @teto @jonringer