Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.fasttext: 0.2.0 -> 0.9.1 #64640

Merged
merged 1 commit into from Jul 12, 2019
Merged

pythonPackages.fasttext: 0.2.0 -> 0.9.1 #64640

merged 1 commit into from Jul 12, 2019

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Changes:

https://github.com/facebookresearch/fastText/releases/tag/v0.9.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk danieldk requested a review from FRidh as a code owner July 11, 2019 17:59
@danieldk
Copy link
Contributor Author

@GrahamcOfBorg build pythonPackages.fasttext python3Packages.fasttext

jonringer
jonringer approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ nix-review pr 64640 passes on NixOS
diff LGTM

[4 built, 8 copied (80.1 MiB), 11.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/64640
2 package were build:
python27Packages.fasttext python37Packages.fasttext

@costrouc
Copy link
Member

Nix review passed

Result of nix-review pr 64640 1

2 package were build:
  • python27Packages.fasttext
  • python37Packages.fasttext

@teto
Copy link
Member

teto commented Jul 12, 2019

Thanks for the package and the reviews.

@teto teto merged commit f4ecf17 into NixOS:master Jul 12, 2019
@danieldk danieldk deleted the python-fasttext-0.9.1 branch August 17, 2020 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danieldk @costrouc @teto @jonringer