Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tacacs+: init 4.0.4.28 #64595

Merged
merged 1 commit into from Sep 1, 2019
Merged

tacacs+: init 4.0.4.28 #64595

merged 1 commit into from Sep 1, 2019

Conversation

0x4A6F
Copy link
Member

@0x4A6F 0x4A6F commented Jul 10, 2019

Motivation for this change

Adding package for a TACACS+ implementation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@0x4A6F 0x4A6F marked this pull request as ready for review July 10, 2019 19:47
@mmahut
Copy link
Member

mmahut commented Jul 11, 2019

@GrahamcOfBorg build tacacs+

@0x4A6F
Copy link
Member Author

0x4A6F commented Jul 11, 2019

I"m not certain, how to proceed on the licensing dimension of this PR.

   Copyright (c) 1995-1998 by Cisco systems, Inc.

   Permission to use, copy, modify, and distribute this software for
   any purpose and without fee is hereby granted, provided that this
   copyright and permission notice appear on all copies of the
   software and supporting documentation, the name of Cisco Systems,
   Inc. not be used in advertising or publicity pertaining to
   distribution of the program without specific prior permission, and
   notice be given in supporting documentation that modification,
   copying and distribution is by permission of Cisco Systems, Inc.

   Cisco Systems, Inc. makes no representations about the suitability
   of this software for any purpose.  THIS SOFTWARE IS PROVIDED ``AS
   IS'' AND WITHOUT ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING,
   WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
   FITNESS FOR A PARTICULAR PURPOSE.

@0x4A6F
Copy link
Member Author

0x4A6F commented Aug 22, 2019

cc @adisbladis

aanderse
aanderse requested changes Aug 31, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a package that might benefit from also having a NixOS service. If that is true, were you interested in working on that as well?

pkgs/servers/tacacs+/default.nix Outdated Show resolved Hide resolved
pkgs/servers/tacacs+/default.nix Outdated Show resolved Hide resolved
pkgs/servers/tacacs+/default.nix Outdated Show resolved Hide resolved
pkgs/servers/tacacs+/default.nix Show resolved Hide resolved
@0x4A6F 0x4A6F force-pushed the master-tacacs+ branch 2 times, most recently from ebed406 to 3c213e9 Compare August 31, 2019 21:25
@0x4A6F
Copy link
Member Author

0x4A6F commented Aug 31, 2019

This seems like a package that might benefit from also having a NixOS service. If that is true, were you interested in working on that as well?

Yes, I'd like to work on a service after this PR.

@0x4A6F 0x4A6F requested a review from alyssais as a code owner August 31, 2019 21:37
@alyssais
Copy link
Member

alyssais commented Aug 31, 2019 via email

@0x4A6F 0x4A6F force-pushed the master-tacacs+ branch 2 times, most recently from 460b6fe to aeec3d9 Compare September 1, 2019 07:28
aanderse
aanderse requested changes Sep 1, 2019
View reviewed changes
pkgs/servers/tacacs+/default.nix Outdated Show resolved Hide resolved
aanderse
aanderse approved these changes Sep 1, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aanderse
Copy link
Member

aanderse commented Sep 1, 2019

@GrahamcOfBorg build tacacs+

@adisbladis adisbladis merged commit 8c76f18 into NixOS:master Sep 1, 2019
@0x4A6F 0x4A6F deleted the master-tacacs+ branch September 2, 2019 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis adisbladis approved these changes

@aanderse aanderse aanderse approved these changes

@alyssais alyssais Awaiting requested review from alyssais

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@0x4A6F @mmahut @alyssais @aanderse @adisbladis