Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virt-manager: depends on gtksourceview4, gst-plugins-{base,good} #64618

Closed
wants to merge 1 commit into from
Closed

virt-manager: depends on gtksourceview4, gst-plugins-{base,good} #64618

wants to merge 1 commit into from

Conversation

astsmtl
Copy link
Contributor

@astsmtl astsmtl commented Jul 11, 2019 •
edited

Motivation for this change

Unable to open virtual machine view in virt-manager. Unable to use SPICE client.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@astsmtl
Copy link
Contributor Author

astsmtl commented Jul 11, 2019

maintainer cc: @qknight @offlinehacker @fpletz

@FRidh
Copy link
Member

FRidh commented Jul 11, 2019

@GrahamcOfBorg eval

@offlinehacker
Copy link
Contributor

I needed some additional dependencies as in virt-viewer for spice display to work. I haven't made pull request. So can you add these additional dependencies, or I can make pull request later this week?

@astsmtl
Copy link
Contributor Author

astsmtl commented Jul 11, 2019

Yes, I'll try to add SPICE too. But don't hesitate to create you own PR if I will not update this request soon. :)

@worldofpeace worldofpeace mentioned this pull request Jul 11, 2019
Merged
10 tasks
@offlinehacker
Copy link
Contributor

Ok, I will update with additional commit to this pull request tomorrow

@astsmtl astsmtl changed the title virt-manager: depends on gtksourceview4 virt-manager: depends on gtksourceview4, gst-plugins-{base,good} Jul 12, 2019
@astsmtl
Copy link
Contributor Author

astsmtl commented Jul 12, 2019

Added dependency on GStreamer plugins for SPICE.

@worldofpeace
Copy link
Contributor

It seems the competing PR was merged #64627 sorry about that.

@astsmtl astsmtl deleted the fix-virt-manager branch July 15, 2019 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@qknight qknight Awaiting requested review from qknight

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@astsmtl @FRidh @offlinehacker @worldofpeace @Janik-Haag