Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd: 3.3.1 -> 3.3.13 #64548

Merged
merged 3 commits into from Jul 10, 2019
Merged

etcd: 3.3.1 -> 3.3.13 #64548

merged 3 commits into from Jul 10, 2019

Conversation

edef1c
Copy link
Member

@edef1c edef1c commented Jul 9, 2019 •
edited

Motivation for this change

We're over a year behind on etcd releases, and there have been a lot of bugfixes and improvements since.
While I would've liked to keep them, the release branch drops the tools
directory as of v3.3.4, seemingly without explanation. master appears to contain them, so they might return at some point.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@edef1c
etcd: 3.3.1 -> 3.3.13
8578d7a 
While I would've liked to keep them, the release branch drops the tools
directory as of v3.3.4, seemingly without explanation:
etcd-io/etcd@074e417

master appears to contain them, so they might return at some point.
@edef1c
nixos/tests: include the etcd-cluster test in all-tests.nix
950d91c 
We seem to have had this test for quite a while, but nothing seems to
reference it.
@ofborg ofborg bot added the 6.topic: nixos label Jul 9, 2019
@edef1c
Copy link
Member Author

edef1c commented Jul 10, 2019

Seems that test never worked to begin with. I've tossed a waitUntilSucceeds in there, doesn't seem too unreasonable for distributed systems.

@GrahamcOfBorg test etcd etcd-cluster

mmahut
mmahut approved these changes Jul 10, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review without any failures
  • run and tested the binaries

@edef1c edef1c merged commit 4a633b5 into master Jul 10, 2019
@edef1c edef1c deleted the etcd-3.3.13 branch July 10, 2019 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edef1c @mmahut