iputils: 20190515 -> 20190709 #64554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/iputils/iputils/releases/tag/s20190709 See release notes for details, but of particular note is that this expression is now quite simpler due to the following: * ninfod now builds w/nettle! * update includes patches we fetched from upstream * cross should be handled now, during move to meson * prelim testing confirms, meson makes it much easier to get things right re:explanation given in comment (not propagating host/target info) * issue re:musl+idn2 appears resolved re:compilation, but results in unclear runtime errors regarding "invalid flags". Keep disabled as before as this is clearer at the expression level and reports failure to resolve instead which is a bit clearer. (testing with systemd-less iputils) This also means our iputils is openssl-free, which if nothing else is a nice reduction in trans. size :). (quick imperfect comparison shows: 39MB -> 35MB w/glibc 11.4 -> 7.9 w/musl ) iputils: nvm no IDN w/musl iputils: nvm keep idn disabled w/musl
dtzWill
force-pushed
the
update/iputils-20190709
branch
from
9cc04b8
to
61572ba
Compare
|
No dice re:musl, my mistake. Still, goodness to be had! :) |
|
@dtzWill: Thanks :) The diff LGTM and the expression is finally a bit cleaner 🎉 Unfortunately I'm a bit short on time and cannot really test it extensively atm but from you comments everything seems to be fine and ready to merge. |
|
@GrahamcOfBorg test networking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://github.com/iputils/iputils/releases/tag/s20190709
See release notes for details,
but of particular note is that
this expression is now quite simpler
due to the following:
to get things right re:explanation given in comment
(not propagating host/target info)
This also means our iputils is openssl-free,
which if nothing else is a nice reduction in trans. size :).
(quick imperfect comparison shows:
39MB -> 35MB w/glibc
11.4 -> 7.9 w/musl
)
Last outstanding issue in my mind re:this is to check what was brokenre:musl and idn2 previously and ensure it wasn't something that only
appeared at runtime. I believe it wouldn't compile but just want to
check-- anyway it compiles and seems to work now so, hooray! \o/
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)