Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smlnj: 110.85 -> 110.91 #64553

Merged
merged 2 commits into from Jul 13, 2019
Merged

smlnj: 110.85 -> 110.91 #64553

merged 2 commits into from Jul 13, 2019

Conversation

vaibhavsagar
Copy link
Member

@vaibhavsagar vaibhavsagar commented Jul 10, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from thoughtpolice July 10, 2019 01:51
@thoughtpolice
Copy link
Member

@GrahamcOfBorg build smlnj

@vaibhavsagar
Copy link
Member Author

FWIW this wasn't working on x86_64-darwin before either: #55287.

@thoughtpolice
Copy link
Member

Can we just go ahead and restrict those platforms anyway, then? No point in even having the evaluator or build machines spend time on it.

@vaibhavsagar
Copy link
Member Author

Sure!

@FRidh
Copy link
Member

FRidh commented Jul 13, 2019

@GrahamcOfBorg build smlnj

@FRidh FRidh merged commit 0e02937 into NixOS:master Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vaibhavsagar @thoughtpolice @FRidh