Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm_*,clang_*: allow src overrides #64647

Merged
merged 1 commit into from Jul 17, 2019

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jul 12, 2019

Motivation for this change

While implementing #64319 it was discovered that it is not possible to override src for llvm and clang because the string interpolation of src is used to define an unpackPhase. This PR changes it to using environment variable so that it can be easily changed with overrideAttrs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested compilation of all pkgs that depend on this change using nix-review pr --build-args "--option build-use-sandbox false" 64647 -p clang_35 -p clang_38 -p clang_39 -p clang_4 -p clang_5 -p clang_6 -p clang_7 -p clang_8 -p llvm_35 -p llvm_38 -p llvm_39 -p llvm_4 -p llvm_5 -p llvm_6 -p llvm_7 -p llvm_8
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh FRidh merged commit 325f37f into NixOS:staging Jul 17, 2019
@veprbl veprbl deleted the pr/llvm_clang_src_overrides branch December 1, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants