llvm_*,clang_*: allow src overrides #64647
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
While implementing #64319 it was discovered that it is not possible to override
src
forllvm
andclang
because the string interpolation ofsrc
is used to define anunpackPhase
. This PR changes it to using environment variable so that it can be easily changed withoverrideAttrs
.Things done
sandbox
innix.conf
on non-NixOS)nix-review pr --build-args "--option build-use-sandbox false" 64647 -p clang_35 -p clang_38 -p clang_39 -p clang_4 -p clang_5 -p clang_6 -p clang_7 -p clang_8 -p llvm_35 -p llvm_38 -p llvm_39 -p llvm_4 -p llvm_5 -p llvm_6 -p llvm_7 -p llvm_8
./result/bin/
)nix path-info -S
before and after)