Create toast action setter #17780
Merged
Create toast action setter #17780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 11, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1686786
branch
from
38a917a
to
36334a0
Compare
Additionally, this CL adds support for passing Elements as action in showToast, using the action setter. This change is the latest in a series of changes implementing new behavior added to the toast explainer in PR #43 jackbsteinberg/std-toast#43. Bug: 972945 Change-Id: I46004883cb3b794981029aa02369918dd0077391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686786 Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org> Reviewed-by: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#676482}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1686786
branch
from
36334a0
to
f7ffd40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, this CL adds support for passing Elements
as action in showToast, using the action setter.
This change is the latest in a series of changes implementing
new behavior added to the toast explainer in PR #43
jackbsteinberg/std-toast#43.
Bug: 972945
Change-Id: I46004883cb3b794981029aa02369918dd0077391
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686786
Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org>
Reviewed-by: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676482}