Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitAndTools.hub: 2.12.1 -> 2.12.2 #64652

Merged
merged 1 commit into from Jul 12, 2019
Merged

gitAndTools.hub: 2.12.1 -> 2.12.2 #64652

merged 1 commit into from Jul 12, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Jul 12, 2019

Motivation for this change

Update gitAndTools.hub to the latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xrelkd
Copy link
Contributor Author

xrelkd commented Jul 12, 2019

Looks like upstream uses go modules, should we update the expression to use buildGoModule?

@worldofpeace
Copy link
Contributor

Looks like upstream uses go modules, should we update the expression to use buildGoModule?

Not sure, they still appear to be vendored.

worldofpeace
worldofpeace approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, build executes.

@worldofpeace worldofpeace merged commit 215497e into NixOS:master Jul 12, 2019
@xrelkd xrelkd deleted the update/gitAndTools.hub branch July 13, 2019 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xrelkd @worldofpeace