Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electrum 3.3.8, optional qt, darwin fixes #64636

Merged
merged 2 commits into from Jul 12, 2019
Merged

electrum 3.3.8, optional qt, darwin fixes #64636

merged 2 commits into from Jul 12, 2019

Conversation

arcnmx
Copy link
Member

@arcnmx arcnmx commented Jul 11, 2019

Motivation for this change
nix path-info -Sh -f . electrum '((import ./. { }).electrum.override { enableQt = false; })' 
/nix/store/nghcaigbxqx5z856aayp2wzdrjra6vv0-electrum-3.3.8	 450.5M
/nix/store/zj2jscg0w8shsxqfp9xf4zdcck4fdqn1-electrum-3.3.8	   1.5G

darwin build tested/logged here

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@arcnmx
electrum: 3.3.7 -> 3.3.8
769f992
@arcnmx
electrum: optional qt5 and darwin fixes
36f9da4 
qt5 is often broken on darwin, and it's a massive closure when there's
a curses interface and CLI to use instead.
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jul 11, 2019
@joachifm
Copy link
Contributor

@GrahamcOfBorg build electrum

@joachifm joachifm merged commit f8a9a50 into NixOS:master Jul 12, 2019
@arcnmx arcnmx deleted the electrum-update branch July 28, 2019 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arcnmx @joachifm