CSS @media (width: *px) may not work if devicePixelRatio is greater than 1. #17759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 10, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1695522
branch
4 times, most recently
from
b1795e4
to
9a44157
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1695522
branch
2 times, most recently
from
cb5e963
to
8a362a4
Compare
…han 1.
When devicePixelRatio is greater than 1, the viewport size of the CSS media
query may appear as non-integers. This can happen in Chrome for Android if
the UseZoomForDSF flag is enabled.
For example:
<meta name="viewport" content="width=device-width, initial-scale=1">
<style>
@media (width: 393px) {
p {
color: red;
}
}
</style>
<p>text</p>
If the device width is 1081 physical pixels and devicePixelRatio is 2.75. The
viewport width of the CSS media query will be 393.091px.
Change-Id: I25ee4da1ebdbd57202fa8c5e360138a8058f578f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695522
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680047}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1695522
branch
from
8a362a4
to
3523928
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When devicePixelRatio is greater than 1, the viewport size of the CSS media
query may appear as non-integers. This can happen in Chrome for Android if
the UseZoomForDSF flag is enabled.
For example:
<meta name="viewport" content="width=device-width, initial-scale=1">
<style>
@media (width: 393px) {
p {
color: red;
}
}
</style>
<p>text</p>
If the device width is 1081 physical pixels and devicePixelRatio is 2.75. The
viewport width of the CSS media query will be 393.091px.
Change-Id: I25ee4da1ebdbd57202fa8c5e360138a8058f578f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695522
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#680047}