Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1528061] wptrunner sends non-blocking message when handling fonts on Windows. #17793

Merged
merged 1 commit into from Jul 12, 2019

Conversation

moz-wptsync-bot
Copy link
Collaborator

This changes the wptrunner to use SendNotifyMessageW instead of SendMessageW
when installing and removing fonts on Windows. The difference between these calls
is that SendNotifyMessageW will not block on each window processing the message
while SendMessageW will. This addresses an issue where the wptrunner would stall
if a window was not processing the font added or removed message.

Differential Revision: https://phabricator.services.mozilla.com/D37617

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1528061
gecko-commit: cde6d92a2230097c57233c6fa215e746ea672c0e
gecko-integration-branch: autoland
gecko-reviewers: jgraham

This changes the wptrunner to use SendNotifyMessageW instead of SendMessageW
when installing and removing fonts on Windows. The difference between these calls
is that SendNotifyMessageW will not block on each window processing the message
while SendMessageW will. This addresses an issue where the wptrunner would stall
if a window was not processing the font added or removed message.

Differential Revision: https://phabricator.services.mozilla.com/D37617

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1528061
gecko-commit: cde6d92a2230097c57233c6fa215e746ea672c0e
gecko-integration-branch: autoland
gecko-reviewers: jgraham
@wpt-pr-bot wpt-pr-bot added infra wptrunner The automated test runner, commonly called through ./wpt run labels Jul 11, 2019
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@moz-wptsync-bot moz-wptsync-bot merged commit a3d0b05 into master Jul 12, 2019
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1528061 branch July 12, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra mozilla:gecko-sync wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants