Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.optuna: init at 0.13.0 #64642

Merged
merged 4 commits into from Jul 13, 2019
Merged

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Jul 11, 2019

Motivation for this change

Listened to an awesome optuna talk at SciPy! So I wanted to contribute the package to nixpkgs

This closes PR #31954

Things done
  • pythonPackages.scikit-optimize: init at 0.6
  • pythonPackages.optuna: init at 0.13.0
  • pythonPackages.lightgbm: init at 2.2.3
  • pythonPackages.cliff: init at 2.15.0

cc: @wd15 @g-votte thanks to the awesome nix and optuna talks 馃槃

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc
Copy link
Member Author

Nix review passed

Result of nix-review pr 64642 1

6 package were build:
  • python27Packages.lightgbm
  • python27Packages.scikit-optimize
  • python37Packages.cliff
  • python37Packages.lightgbm
  • python37Packages.optuna
  • python37Packages.scikit-optimize

@risicle
Copy link
Contributor

risicle commented Jul 13, 2019

For me, python27Packages.cliff fails to build simply because of its dependency cmd2 being apparently broken on py27 at the moment (deja vu?).

@costrouc
Copy link
Member Author

Didn't you just remove python 2.7 support for cmd2? #62998 so I don't think this is an issue

@FRidh FRidh merged commit b335544 into NixOS:master Jul 13, 2019
@risicle
Copy link
Contributor

risicle commented Jul 13, 2019

That's what the deja vu was!

Not sure why my machine was attempting to build it - possible some stale files somewhere...

@risicle
Copy link
Contributor

risicle commented Jul 13, 2019

p.s. lightgbm does fail to build for me on macos 10.13 - I'll see what I can do about it.

@costrouc
Copy link
Member Author

Ahh gotcha. Thanks I would definitely appreciate osx support for the binary.

@risicle
Copy link
Contributor

risicle commented Jul 13, 2019

#64711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants