Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.anonip: init at 1.0.0 #64628

Merged
merged 1 commit into from Jul 11, 2019
Merged

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Jul 11, 2019

Motivation for this change

init at 1.0.0, fixes #64573.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut mmahut requested a review from FRidh as a code owner July 11, 2019 14:05
@mmahut mmahut changed the title pythonPackages.anonip: init at 1.0.0 [WIP] pythonPackages.anonip: init at 1.0.0 Jul 11, 2019
@mmahut mmahut changed the title [WIP] pythonPackages.anonip: init at 1.0.0 pythonPackages.anonip: init at 1.0.0 Jul 11, 2019
@mmahut
Copy link
Member Author

mmahut commented Jul 11, 2019

@GrahamcOfBorg build python3Packages.anonip

@worldofpeace
Copy link
Contributor

Can we maybe also run the unit tests https://github.com/DigitaleGesellschaft/Anonip/blob/master/tests.py ?

@mmahut
Copy link
Member Author

mmahut commented Jul 11, 2019

Can we maybe also run the unit tests https://github.com/DigitaleGesellschaft/Anonip/blob/master/tests.py ?

Done, I'm now building it from GitHub as the tests are not in pypi. Rebased.

@worldofpeace
Copy link
Contributor

Can we maybe also run the unit tests https://github.com/DigitaleGesellschaft/Anonip/blob/master/tests.py ?

Done, I'm now building it from GitHub as the tests are not in pypi. Rebased.

Lol, no tests in tarball and it's like one file. Looking now.

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last suggestion. Builds on all interpreters.

pkgs/development/python-modules/anonip/default.nix Outdated Show resolved Hide resolved
@worldofpeace worldofpeace merged commit 95647d8 into NixOS:master Jul 11, 2019
@mmahut mmahut deleted the anonip branch July 11, 2019 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AnonIp - Anonymize IP addresses in log files
2 participants