Fix regression in webdriver tests #17754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A large number of tests in webdriver directory are currently failing, due to a change in the parameters of Find.css method by PR web-platform-tests#17260, which broke any tests that still supply the old parameters. This commit changes the parameter order and uses default parameter value to make the parameter list compatible with the old one.
wpt-pr-bot
added
infra
webdriver
wg-testing_browser
wptrunner
|
For comparison, https://wpt.fyi/results/webdriver?sha=720ddb0305&label=master&max-count=1 shows the result from webdriver directory before PR #17260, while https://wpt.fyi/results/webdriver?sha=a9d6d1b058&label=master&max-count=1 shows the result after. This PR should restore the pass rate. |
jgraham
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A large number of tests in webdriver directory are currently failing,
due to a change in the parameters of Find.css method by PR #17260,
which broke any tests that still supply the old parameters.
This commit changes the parameter order and uses default parameter value
to make the parameter list compatible with the old one.