Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox-bin: 67.0.4 -> 68.0 [Critical security fixes] #64577

Merged
merged 1 commit into from Jul 13, 2019
Merged

firefox-bin: 67.0.4 -> 68.0 [Critical security fixes] #64577

merged 1 commit into from Jul 13, 2019

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Jul 10, 2019

Motivation for this change
  • Critical security fixes
  • Other improvements

https://www.mozilla.org/en-US/firefox/68.0/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2019-21/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I could not build the source package. It results in OSError: [Errno 17] File exists: '/build/firefox-68.0/obj-x86_64-pc-linux-gnu/_virtualenvs/init/lib/python2.7/lib-dynload'.
As the update contains critical security fixes, I made this PR only for firefox-bin rather than tackling the error. I will investigate it in the weekend if anyone don't.

@andir
Copy link
Member

andir commented Jul 10, 2019 •
edited

Thank you for looking at this! 👍

I could not build the source package. It results in OSError: [Errno 17] File exists: '/build/firefox-68.0/obj-x86_64-pc-linux-gnu/_virtualenvs/init/lib/python2.7/lib-dynload'.
As the update contains critical security fixes, I made this PR only for firefox-bin rather than tackling the error. I will investigate it in the weekend if anyone don't.

Before I went on vacation I tried building the latest beta release. Removing the obj-x86_64-linux-gnu directory seemed to be fine. That seems to be an build artifact from the firefox release process that shouldn't be there(?).

Afterwards I was running into an issue with rust-cbindgen (mozilla/cbindgen#338) on newer version. I did not investigate further where that comes from. With my currently very spotty internet connection I can not continue on it as well. Manually verifying and disabling tests for now could work.

@veprbl veprbl added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Jul 10, 2019
gloaming
gloaming approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@gloaming gloaming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the update script and confirmed the results.

nix-review:

https://github.com/NixOS/nixpkgs/pull/64577
4 package were build:
dropbox dropbox-cli firefox-bin-unwrapped mate.caja-dropbox

Tested firefox binaries for en-GB and en-US.
Closure size is slightly down.

LGTM

vcunat
vcunat approved these changes Jul 13, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs OK for me.

@vcunat vcunat merged commit ac31e53 into NixOS:master Jul 13, 2019
vcunat added a commit that referenced this pull request Jul 13, 2019
@vcunat
Merge #64577: firefox-bin: 67.0.4 -> 68.0 (security)
dc121c7
vcunat added a commit that referenced this pull request Jul 13, 2019
@vcunat
Merge #64577: firefox-bin: 67.0.4 -> 68.0 (security)
1dddf80 
(cherry picked from commit dc121c7)
@vcunat
Copy link
Member

vcunat commented Jul 13, 2019

Also, re-tested on 19.03 and pushed as 1dddf80.

@taku0 taku0 mentioned this pull request Jul 14, 2019
Closed
10 tasks
@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@gloaming gloaming gloaming approved these changes

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@taku0 @andir @vcunat @gloaming @veprbl @TredwellGit