Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.django-csp: init at 3.5 #64576

Merged
merged 1 commit into from Aug 15, 2019
Merged

pythonPackages.django-csp: init at 3.5 #64576

merged 1 commit into from Aug 15, 2019

Conversation

MrMebelMan
Copy link
Contributor

Motivation for this change

Just adding a missing package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@MrMebelMan MrMebelMan requested a review from FRidh as a code owner July 10, 2019 14:14
@mmahut
Copy link
Member

mmahut commented Aug 13, 2019

@MrMebelMan do you mind updating the name please?

@MrMebelMan MrMebelMan force-pushed the init/django-csp-nonce branch 2 times, most recently from 378c2bd to 0b7abe6 Compare August 14, 2019 16:30
@MrMebelMan
Copy link
Contributor Author

@MrMebelMan do you mind updating the name please?

done & rebased master

@worldofpeace
Copy link
Contributor

worldofpeace commented Aug 14, 2019 •
edited

Why is it django-csp-nonce and not django-csp in all-packages.nix?

@MrMebelMan
Copy link
Contributor Author

Why is it django-csp-nonce and not django-csp in all-packages.nix?

oh... I think i've messed it up when packaging both django-csp and django-csp-nonce.

Changed to django-csp.

@worldofpeace worldofpeace changed the title pythonPackages.django-csp-nonce: init at 3.5 pythonPackages.django-csp: init at 3.5 Aug 15, 2019
@worldofpeace worldofpeace merged commit 3553c99 into NixOS:master Aug 15, 2019
@worldofpeace
Copy link
Contributor

Thanks @MrMebelMan ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MrMebelMan @mmahut @worldofpeace