Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mako: install dbus service file #64593

Merged
merged 1 commit into from Jul 11, 2019
Merged

mako: install dbus service file #64593

merged 1 commit into from Jul 11, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jul 10, 2019 •
edited by ghost

Motivation for this change

Absence of dbus service file is a main showstopper for me. I think there is no strict reason to wait for 1.4 release just because of that, instead add it via patch.

Tested for work at my side.

Reference #57602 (comment)

cc @primeos @dywedir

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from dywedir July 10, 2019 17:54
@worldofpeace worldofpeace merged commit b9338ee into NixOS:master Jul 11, 2019
@ghost
Copy link
Author

ghost commented Jul 11, 2019

@worldofpeace Thank you!

@ghost ghost deleted the mako branch July 11, 2019 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dywedir dywedir Awaiting requested review from dywedir

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@worldofpeace