[css-transforms] Avoid using assert_own_property on testing style properties. #17778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorisChiou
changed the title
These `assert_own_property` tests cause these CSS tests to fail on Firefox only, and I think these properties are not supposted to be own properties, so use a similar way as web-platform-tests#16892, to test the existence of these properties.
BorisChiou
force-pushed
the
transform/property_check
branch
from
899bef6
to
b54697e
Compare
emilio
approved these changes
Jul 11, 2019
natechapin
pushed a commit
to natechapin/wpt
that referenced
this pull request
Aug 23, 2019
…eb-platform-tests#17778) These `assert_own_property` tests cause these CSS tests to fail on Firefox only, and I think these properties are not supposted to be own properties, so use a similar way as web-platform-tests#16892, to test the existence of these properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These
assert_own_propertytests cause these CSS tests to fail on Firefox only, and I think these properties are not supposted to be own properties, so use a similar way as #16892, to test the existence of these properties.cc @emilio