New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cordless: init at 2019-06-13 #64609
cordless: init at 2019-06-13 #64609
Conversation
''; | ||
homepage = https://www.github.com/Bios-Marcel/cordless; | ||
license = licenses.bsd3; | ||
maintainers = [ "Marcel Schramm <marceloschr@googlemail.com>" ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind moving this to maintainers/maintainer-list.nix
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, will do
name = "cordless-${version}"; | ||
version = "2019-06-13"; | ||
|
||
src = fetchurl { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use fetchFromGitHub
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, but may I ask why that's better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fetchFromGitHub
is better to use when you don't rely on a release tarball because nix can do some sort of caching that it can't with fetchurl
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see, so it caches parts that are the same instead of the whole tarball, which would be useless.
@GrahamcOfBorg build cordless |
After applying the requested changes I am getting this:
However, none of those hashsums appears in my file. What am I doing wrong herre? Here is what I got so far: { stdenv, buildGoModule, fetchFromGitHub }:
buildGoModule rec {
pname = "cordless";
version = "2019-06-13";
src = fetchFromGitHub {
owner = "Bios-Marcel";
repo = pname;
rev = version;
sha256 = "ef9c4db21b7c75a5263281ed783c905b47e752f8b596575e0a41cd6e7d450566";
};
doCheck = true;
modSha256 = "08a1dg4d7fjdy8w3sbri3ik8k7c1snpa0rzwinal6inzmdyancys";
subPackages = [ "." ];
meta = with stdenv.lib; {
description = "A third party Discord client";
longDescription = ''
Cordless is a third party Discord client that runs on the
commandline and aims to have a low memory footprint and
bandwidth consumption.
'';
homepage = https://www.github.com/Bios-Marcel/cordless;
license = licenses.bsd3;
maintainers = [ maintainers.biosmarcel ];
platforms = platforms.linux;
};
} |
I just tried building this. After changing Weird |
ping (triage) |
Anything blocking this other than the fetchFromGitHub thing? |
Well, this is quite outdated either way. Should I just make a new PR? |
I don't see the problem with updating this one. FWIW, it still works fine (though I updated the version, and changed it to fetchFromGitHub) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address mmahut's change requests.
Thank you for your contributions. This has been automatically marked as stale because it has had no activity for 180 days. If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity. Here are suggestions that might help resolve this more quickly:
|
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)