Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quickjs: init at 2019-07-09 #64668

Closed
wants to merge 1 commit into from
Closed

quickjs: init at 2019-07-09 #64668

wants to merge 1 commit into from

Conversation

stesie
Copy link
Member

@stesie stesie commented Jul 12, 2019

Motivation for this change

QuickJS is a new Javascript engine recently published by Fabrice Bellard

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stesie
Copy link
Member Author

stesie commented Jul 12, 2019

Thanks @tadeokondrak for the feedback :)

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build quickjs

@ivan ivan mentioned this pull request Nov 16, 2019
Merged
10 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/87

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/76

@timokau
Copy link
Member

timokau commented Dec 4, 2019

Obsolete since #73515 was merged (thanks @yorickvP).

@timokau timokau closed this Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadeokondrak tadeokondrak tadeokondrak left review comments

@worldofpeace worldofpeace worldofpeace requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stesie @worldofpeace @nixos-discourse @timokau @tadeokondrak