Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zpaq: fix version and pull from github #64604

Merged
merged 1 commit into from Jul 11, 2019
Merged

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Repology didn't like we were missing the "." between major and minor.

The repo was also migrated to git and is using it for releases, so transfered to pulling from github.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

$ nix path-info -Sh ./result
/nix/store/i5b30y5plwgblzl8mfgcnnnb4ql57f35-zpaq-715      32.7M
$ nix path-info -Sh ./result
/nix/store/v0i0wf7w6aqq3m8v5zqxc55xyapkck3x-zpaq-7.15     32.7M
$ nix-review wip
...
[1 built, 0.0 MiB DL]
1 package were build:
zpaq
$ ./result/bin/zpaq
zpaq v7.15 journaling archiver, compiled Jan  1 1970
Usage: zpaq command archive[.zpaq] files... -options...

@ofborg ofborg bot requested a review from 7c6f434c July 10, 2019 20:25
@FRidh FRidh merged commit 8418931 into NixOS:master Jul 11, 2019
@jonringer jonringer deleted the update-zpaq branch July 11, 2019 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants