Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proot: 20190510 -> 5.1.0 #64605

Closed
wants to merge 1 commit into from
Closed

proot: 20190510 -> 5.1.0 #64605

wants to merge 1 commit into from

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Fix repology entry. and update the package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

$ nix path-info -Sh ./result
/nix/store/1gz638vyk1k8cmypj8zrflaj3yfg9jdy-proot-20190510 94.4M
$ nix path-info -Sh ./result
/nix/store/qzwdwjsqn9px5dfs8g5rrppqqjcnpppx-proot-5.1.0 94.1M

$ nix-review wip
...
[2 built, 14 copied (21.6 MiB), 4.4 MiB DL]
2 package were build:
proot udocker

@matthewbauer
Copy link
Member

@GrahamcOfBorg build proot pkgsStatic.proot

@ofborg ofborg bot requested review from dtzWill and veprbl July 10, 2019 21:16
@matthewbauer
Copy link
Member

This release appears to be from 2014: https://github.com/proot-me/proot/releases/tag/v5.1.0. There are numerous fixes we need to have available:

proot-me/proot@v5.1.0...master

@jonringer
Copy link
Contributor Author

you are absolutely correct.. ill flag it on repology then.

@jonringer
Copy link
Contributor Author

Decided against flagging it on repology, there an open issue here proot-me/proot#127 already for cutting a new release. Hopefully a new release reflects the current state of the project :(

@jonringer
Copy link
Contributor Author

Closing issue due to nature of package releases.

@jonringer jonringer closed this Jul 10, 2019
@jonringer jonringer deleted the update-proot branch December 1, 2019 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

@veprbl veprbl Awaiting requested review from veprbl

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @matthewbauer