Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-align] Computed values for align*, justify* #17800

Merged
merged 1 commit into from Jul 19, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jul 12, 2019

Computed values are as specified, with an exception for justify-items:
"If the legacy keyword appears on its own (without an accompanying
left, right, or center keyword): if the inherited value of
justify-items includes the legacy keyword, this value computes to
the inherited value; otherwise it computes to normal."
https://drafts.csswg.org/css-align-3/#propdef-justify-items

Change-Id: I61a4baba66d32aad9d7eb3b0e62d316a31bcb18d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699263
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Chris Nardi <cnardi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679232}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

Computed values are as specified, with an exception for justify-items:
"If the legacy keyword appears on its own (without an accompanying
left, right, or center keyword): if the inherited value of
justify-items includes the legacy keyword, this value computes to
the inherited value; otherwise it computes to normal."
https://drafts.csswg.org/css-align-3/#propdef-justify-items

Change-Id: I61a4baba66d32aad9d7eb3b0e62d316a31bcb18d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699263
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Chris Nardi <cnardi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679232}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants