Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build for gimp-with-plugins against exiv2 0.27.1 #64607

Merged
merged 3 commits into from Aug 18, 2019
Merged

Fix build for gimp-with-plugins against exiv2 0.27.1 #64607

merged 3 commits into from Aug 18, 2019

Conversation

gloaming
Copy link
Contributor

Motivation for this change

Fixes #64586

Things done

Path size 1803392632 vs 1798388408 when building against exiv2 0.26.2018.12.30

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ajs124 ajs124 mentioned this pull request Jul 10, 2019
Closed
10 tasks
worldofpeace
worldofpeace reviewed Jul 11, 2019
View reviewed changes
pkgs/applications/graphics/ufraw/default.nix Outdated
@@ -13,6 +13,17 @@ stdenv.mkDerivation rec {
sha256 = "0pm216pg0vr44gwz9vcvq3fsf8r5iayljhf5nis2mnw7wn6d5azp";
};

patches = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See review at #64353.

Those patches could be improved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roger that.
@neilmayhew could you test the suggested changes and update the patches at sourceforge.net?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gloaming Done. The URLs are:

Not as tidy as before, but I don't think SourceForge provides a way to modify attachments in the issue description. I had to do it by attaching the new files to a comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry I didn't notice your PR before opening this one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't notice your PR before opening this one.

No worries. It might have helped if I'd created an issue as well as a PR. I'll make sure to do that in future.

@worldofpeace worldofpeace self-assigned this Jul 11, 2019
@neilmayhew neilmayhew mentioned this pull request Jul 12, 2019
Closed
10 tasks
@gloaming
Copy link
Contributor Author

Hold up though - I forgot to actually test ufraw properly by opening a photo before. I downloaded a couple to check and it seems the release version is broken!

I dug around a bit more and found that someone is maintaining a fork on GitHub: https://github.com/sergiomb2/ufraw

It includes several distro patches, including the exiv2 fix: sergiomb2/ufraw@a13c0f7
I'm going to go ahead and update to HEAD there, since at least I can actually open one test photo with it, although not the other.

@worldofpeace
Copy link
Contributor

That's sounds fine, I've checked and fedora also uses that fork.

@gloaming
Copy link
Contributor Author

@worldofpeace It appears that GIMP has not supported the ufraw plugin for some time. Should we remove all mention of ufraw.gimpPlugin?

@worldofpeace
Copy link
Contributor

@gloaming I believe that should be fine. If you do this please note you need to add a throw to aliases.nix on gimpPlugins.ufraw to explain the backwards incompatible change.

@worldofpeace
Copy link
Contributor

ping @gloaming

(sorry this is dragging on so long)

@jtojnar
Copy link
Contributor

jtojnar commented Jul 31, 2019 •
edited

Ufraw was working recently to some capacity at least: #37915. What exactly does “GIMP not supporting plug-in” mean?

@gloaming
Copy link
Contributor Author

gloaming commented Jul 31, 2019 •
edited

@jtojnar gimpWithPlugins doesn't have any trace of ufraw in its menus. I tried to open a RAW that opens successfully with standalone ufraw inside GIMP, and it gave me the same message it gives without the ufraw plugin:

gimp-raw-loaders

The message itself implies that ufraw is no longer supported. I also searched for information and couldn't find anything more recent than several years ago...

@gloaming
Copy link
Contributor Author

@gloaming I believe that should be fine. If you do this please note you need to add a throw to aliases.nix on gimpPlugins.ufraw to explain the backwards incompatible change.

@worldofpeace Hmm... Would it be better to put the throw in pkgs/applications/graphics/gimp/plugins/default.nix in case some future traveller looks for it there?

@gloaming
gimpPlugins.gimplensfun: 0.2.4 -> unstable-2018-10-21
15dd447 
Fixes broken build with exiv2-0.27.1 by using gexiv2 instead
@gloaming
Copy link
Contributor Author

Actually, I think it's better to leave it for now. Rebased and checked it still works. @worldofpeace feel free to merge

@jtojnar
Copy link
Contributor

jtojnar commented Aug 14, 2019 •
edited

Okay, I can confirm that opening RAW files through the file dialogue no longer works but the send to GIMP button in UFRaw seems to still require the plug-in:

I downloaded https://raw.pixls.us/getfile.php/2835/nice/Apple%20-%20iPhone%208%20-%2016bit%20(4:3).dng, opened it in UFRaw, started GIMP, and clicked the GIMP icon in the bottom right of UFRaw window.

When running GIMP without ufraw plug-in, I get the following error:

Opening '/tmp/Apple - iPhone 8 - 16bit (4_3).dng_0LQE6Z.ufraw' failed: Could not open '/tmp/Apple - iPhone 8 - 16bit (4_3).dng_0LQE6Z.ufraw' for reading: root element is not <svg>

With the plug-in, It opens the file fine, only complaining about:

Calling error for procedure 'plug-in-metadata-decode-exif':
Procedure 'plug-in-metadata-decode-exif' not found

@gloaming
Copy link
Contributor Author

Ah, right. Happens the same for me. I've left it at just the updates then.

@gloaming
ufraw: 0.22 -> unstable-2019-06-12
debf1db 
The original ufraw repo is no longer maintained, so change
to a new upstream that's collecting patches, including one
we need to fix the build against more recent versions of exiv2.
@gloaming
ufraw: Remove --enable-extras
38b057f 
Don't build the 'dcraw' and 'nikon-curve' binaries, as per ufraw's README:

"Do not package the executables generated by by --enable-extras. These extras
are there for testing the code during development. They are of no interest
to end user. Specifically, if you want to package dcraw, you should use
Dave's original code and not UFRaw's modified code."
@gloaming
Copy link
Contributor Author

Ping @worldofpeace

@worldofpeace worldofpeace merged commit 5c430ff into NixOS:master Aug 18, 2019
@worldofpeace
Copy link
Contributor

Thanks, sorry about the delay on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilmayhew neilmayhew neilmayhew left review comments

@jtojnar jtojnar jtojnar left review comments

@ajs124 ajs124 ajs124 left review comments

@worldofpeace worldofpeace worldofpeace left review comments

Assignees

@worldofpeace worldofpeace

Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gimp-with-plugins does not compile anymore
5 participants
@gloaming @worldofpeace @jtojnar @neilmayhew @ajs124