Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1559276] Part 2: Retire the support for 3-valued syntax for position. #17777

Merged
merged 1 commit into from Jul 11, 2019

Conversation

moz-wptsync-bot
Copy link
Collaborator

According to this resolved spec issue:
w3c/csswg-drafts#2140,
we retire the 3-valued on

  1. object-position
  2. perspective-origin,
  3. mask-position
  4. circle() and ellipse()
    , but still keep the support for background-position.

Besides, I simply run this python script to generate the .ini file:

s = sys.argv[1] + ".ini"
with open(s, "w") as f:
    f.write('[{}]\n'.format(sys.argv[1]))
    f.write('  expected: FAIL\n')
    f.write('  bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1559276\n')

Differential Revision: https://phabricator.services.mozilla.com/D37126

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1559276
gecko-commit: 6ec2809da4e31720cbb59b4ba71616c1c168553e
gecko-integration-branch: autoland
gecko-reviewers: emilio

According to this resolved spec issue:
w3c/csswg-drafts#2140,
we retire the 3-valued <position> on
1. `object-position`
2. `perspective-origin`,
3. `mask-position`
4. `circle()` and `ellipse()`
, but still keep the support for `background-position`.

Besides, I simply run this python script to generate the .ini file:
```
s = sys.argv[1] + ".ini"
with open(s, "w") as f:
    f.write('[{}]\n'.format(sys.argv[1]))
    f.write('  expected: FAIL\n')
    f.write('  bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1559276\n')
```

Differential Revision: https://phabricator.services.mozilla.com/D37126

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1559276
gecko-commit: 6ec2809da4e31720cbb59b4ba71616c1c168553e
gecko-integration-branch: autoland
gecko-reviewers: emilio
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@moz-wptsync-bot moz-wptsync-bot merged commit f93a1a4 into master Jul 11, 2019
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1559276 branch July 11, 2019 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants