Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flashplayer: 32.0.0.207 -> 32.0.0.223 #64568

Merged
merged 1 commit into from Jul 11, 2019
Merged

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Jul 10, 2019

Motivation for this change
  • Important bug fixes.

https://helpx.adobe.com/flash-player/release-note/fp_32_air_32_release_notes.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)

  • Built on platform(s)

    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"

  • Tested execution of all binary files (usually in ./result/bin/)

  • Determined the impact on package closure size (by running nix path-info -S before and after)

  • Ensured that relevant documentation is up to date

  • Fits CONTRIBUTING.md.

  • Built packages

    • nix-env -i -f . -A pkgs.flashplayer
    • nix-build -I nixpkgs=. -o flashplayer_i686 -A pkgsi686Linux.flashplayer
    • nix-build -I nixpkgs=. -o flashplayer_debug -E "(import <nixpkgs> {}).flashplayer.override { debug = true; }"
    • nix-build -I nixpkgs=. -o flashplayer_i686_debug -E "(import <nixpkgs> {}).pkgsi686Linux.flashplayer.override { debug = true; }"
    • nix-build -I nixpkgs=. -o flashplayer_standalone -A pkgs.flashplayer-standalone
    • nix-build -I nixpkgs=. -o flashplayer_standalone_debug -A pkgs.flashplayer-standalone-debugger
    • nix-build -I nixpkgs=. -o chromium -E "(import <nixpkgs> {}).chromium.override { enablePepperFlash = true; }"
  • Played those videos with Firefox (x86_64) and Chromium (x86_64)


@FRidh
Copy link
Member

FRidh commented Jul 11, 2019

Should this be backported?

@taku0
Copy link
Contributor Author

taku0 commented Jul 12, 2019

We don't need to backport this. This contains no security fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants