Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] cyrus_imapd: init at 3.0.11 #64616

Closed
wants to merge 1 commit into from
Closed

[WIP] cyrus_imapd: init at 3.0.11 #64616

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 11, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link
Author

ghost commented Jul 11, 2019

#54012

@ghost
Copy link
Author

ghost commented Jul 11, 2019

The perl scripts can not find the required modules, but otherwise it looks ok.

@ghost ghost changed the title cyrus_imapd: init at 3.0.11 [WIP] cyrus_imapd: init at 3.0.11 Jul 11, 2019
@ghost
Copy link
Author

ghost commented Jul 11, 2019

Can someone tell me where the bad indent is? OfBorg says it should be in line 1, but it looks fine to me.

Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always looking good @petabyteboy 👍

pkgs/servers/mail/cyrus-imapd/default.nix Outdated Show resolved Hide resolved
@FRidh
Copy link
Member

FRidh commented Jul 11, 2019

@GrahamcOfBorg eval

@teto
Copy link
Member

teto commented Jul 12, 2019

@petabyteboy why the WIP ? because of the perl issue : it can't find perl belonging to cyrus_imap or 3rd party plugins ? you might need to create an environment perl.withPackages ?
I am loosely interested in the software (mainly because of the JMAP implementation), I wonder if you plan to add a module (which could make testing the software easier)

@ghost
Copy link
Author

ghost commented Jul 12, 2019

@petabyteboy why the WIP ? because of the perl issue : it can't find perl belonging to cyrus_imap or 3rd party plugins ? you might need to create an environment perl.withPackages ?
I am loosely interested in the software (mainly because of the JMAP implementation), I wonder if you plan to add a module (which could make testing the software easier)

Yes because of the perl thing.
When I start sieveshell, I get this:

Can't load '/nix/store/qv1s3nfwqdk7kncckv0mm554dm1qf5vz-cyrus-imapd-3.0.10/lib/perl5/site_perl/5.28.2/x86_64-linux-thread-multi/auto/Cyrus/SIEVE/managesieve/managesieve.so' for module Cyrus::SIEVE::managesieve: /nix/store/qv1s3nfwqdk7kncckv0mm554dm1qf5vz-cyrus-imapd-3.0.10/lib/perl5/site_perl/5.28.2/x86_64-linux-thread-multi/auto/Cyrus/SIEVE/managesieve/managesieve.so: undefined symbol: sasl_client_step at /nix/store/xnr1miqcjqsvqb6n23zavrvnnyax49bi-perl-5.28.2/lib/perl5/5.28.2/x86_64-linux-thread-multi/DynaLoader.pm line 193.

Some of the bin files will have to be wrapped because they are shell scripts and reference perl without an absolute path.

@ghost
Copy link
Author

ghost commented Dec 14, 2019

I'm wondering if perl should be in nativeBuildInputs or in buildInputs. The perl interpreter is used during the build, but it is also needed at run-time.

@ghost
Copy link
Author

ghost commented Dec 14, 2019

I have fixed PERL5LIB and sieveshell can find the perl libraries in the output, but I am now stuck with a different problem I can not solve:

pbb@amalthea ~/p/nixpkgs> result/bin/sieveshell
Can't load '/nix/store/4g31sxc451qc2425a62cks7r0pvl0p4h-cyrus-imapd-3.0.12/lib/perl5/site_perl/5.30.1/x86_64-linux-thread-multi/auto/Cyrus/SIEVE/managesieve/managesieve.so' for module Cyrus::SIEVE::managesieve: /nix/store/4g31sxc451qc2425a62cks7r0pvl0p4h-cyrus-imapd-3.0.12/lib/perl5/site_perl/5.30.1/x86_64-linux-thread-multi/auto/Cyrus/SIEVE/managesieve/managesieve.so: undefined symbol: sasl_client_step at /nix/store/9a8q20iyq9si8f9sxm2afpd57gap4qlj-perl-5.30.1/lib/perl5/5.30.1/x86_64-linux-thread-multi/DynaLoader.pm line 193.
 at /nix/store/4g31sxc451qc2425a62cks7r0pvl0p4h-cyrus-imapd-3.0.12/bin/.sieveshell-wrapped line 65.
Compilation failed in require at /nix/store/4g31sxc451qc2425a62cks7r0pvl0p4h-cyrus-imapd-3.0.12/bin/.sieveshell-wrapped line 65.
BEGIN failed--compilation aborted at /nix/store/4g31sxc451qc2425a62cks7r0pvl0p4h-cyrus-imapd-3.0.12/bin/.sieveshell-wrapped line 65.
pbb@amalthea ~/p/nixpkgs>

@ghost
Copy link
Author

ghost commented Jan 28, 2020

Small update: I am still interested but could not find a solution to the last problem yet. Suggestions are welcome.

@aanderse
Copy link
Member

@petabyteboy I bet @volth knows the solution to this problem without having to do any research at all...

@stale
Copy link

stale bot commented Jul 27, 2020

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 27, 2020
@ryantm ryantm marked this pull request as draft October 23, 2020 03:06
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 23, 2020
@stale
Copy link

stale bot commented Apr 26, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 26, 2021
@ghost
Copy link
Author

ghost commented Apr 29, 2021

I'm not planning to work on this anymore

@ghost ghost closed this Apr 29, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants