[Gecko Bug 1562701] Move the reframing logic of <details> element into WipeContainingBlock. #17788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to treat a details frame as if it has multiple content insertion points in order to reframe it. We can just put the logic into WipeContainingBlock(). The reftests layout/reftests/details-summary/dynamic-add-*.html also cover adding <summary> into a <details> in various situations. Differential Revision: https://phabricator.services.mozilla.com/D36529 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1562701 gecko-commit: 10faf756124c232c9b460afc72168ea54fa6ab03 gecko-integration-branch: central gecko-reviewers: dbaron
wpt-pr-bot
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to treat a details frame as if it has multiple content
insertion points in order to reframe it. We can just put the logic into
WipeContainingBlock().
The reftests layout/reftests/details-summary/dynamic-add-*.html also
cover adding
Differential Revision: https://phabricator.services.mozilla.com/D36529
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1562701
gecko-commit: 10faf756124c232c9b460afc72168ea54fa6ab03
gecko-integration-branch: central
gecko-reviewers: dbaron