Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1563278] Specify font-family and font-size on the same element in web-platform-test contain-paint-008.html. #17786

Merged
merged 1 commit into from Jul 11, 2019

Conversation

moz-wptsync-bot
Copy link
Collaborator

This patch corrects a likely-inadvertent difference between the CSS in this
testcase vs. its reference case.

This patch fixes a Windows & MacOS off-by-1px spurious failure in this test,
which was probably due to having text whose font-metrics differ from its
line-box (in the testcase) vs. agree with its line-box (in the reference).

While we're here, this patch also adjusts the code-comment in the testcase
to avoid implying that Firefox unconditionally lacks support for containment.
(And to fix a minor grammatical typo, "not need" --> "no need".)

Differential Revision: https://phabricator.services.mozilla.com/D37494

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1563278
gecko-commit: bbcd2af40409fad89375fcaabc5b83d9ae99e99e
gecko-integration-branch: central
gecko-reviewers: TYLin

…-test contain-paint-008.html.

This patch corrects a likely-inadvertent difference between the CSS in this
testcase vs. its reference case.

This patch fixes a Windows & MacOS off-by-1px spurious failure in this test,
which was probably due to having text whose font-metrics differ from its
line-box (in the testcase) vs. agree with its line-box (in the reference).

While we're here, this patch also adjusts the code-comment in the testcase
to avoid implying that Firefox unconditionally lacks support for containment.
(And to fix a minor grammatical typo, "not need" --> "no need".)

Differential Revision: https://phabricator.services.mozilla.com/D37494

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1563278
gecko-commit: bbcd2af40409fad89375fcaabc5b83d9ae99e99e
gecko-integration-branch: central
gecko-reviewers: TYLin
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@moz-wptsync-bot moz-wptsync-bot merged commit 4ab7163 into master Jul 11, 2019
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1563278 branch July 11, 2019 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants