Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacs: add zmq package #64612

Merged
merged 1 commit into from Jul 17, 2019
Merged

emacs: add zmq package #64612

merged 1 commit into from Jul 17, 2019

Conversation

matthewbauer
Copy link
Member

This builds emacs-zmq.so automatically.

Fixes #59774

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer
emacs: add zmq package
7fc87a4 
This builds emacs-zmq.so automatically.

Fixes #59774
@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/installing-packaging-emacs-zmq/3394/4

@matthewbauer
Copy link
Member Author

@GrahamcOfBorg build emacsPackagesNg.zmq

@matthewbauer matthewbauer merged commit 6399cdb into master Jul 17, 2019
@matthewbauer matthewbauer deleted the add-emacs-zmq branch July 18, 2019 21:51
@fritz-k
Copy link

fritz-k commented Jul 23, 2019 •
edited

Building emacsPackagesNg.zmq fails with

config.status: error: cannot find input file: `Makefile.in'
make[1]: *** [Makefile:43: configure] Error 1
make[1]: Leaving directory '/build/source'
make: *** [Makefile:55: src/Makefile] Error 2
builder for '/nix/store/j7cvwzdsfnpkiz3a0i1rw4bijlplxdvq-emacs-zmq-0.10.10.drv' failed with exit code 2

In the "Checks" tab of this PR, the build of emacsPackagesNg failed with the same error.

Edit: Thanks for working on this issue by the way :)

@matthewbauer
Copy link
Member Author

Building emacsPackagesNg.zmq fails with

config.status: error: cannot find input file: `Makefile.in'
make[1]: *** [Makefile:43: configure] Error 1
make[1]: Leaving directory '/build/source'
make: *** [Makefile:55: src/Makefile] Error 2
builder for '/nix/store/j7cvwzdsfnpkiz3a0i1rw4bijlplxdvq-emacs-zmq-0.10.10.drv' failed with exit code 2

In the "Checks" tab of this PR, the build of emacsPackagesNg failed with the same error.

Edit: Thanks for working on this issue by the way :)

Yeah left out the zeromq change. This should fix it:

#65049

@adisbladis
Copy link
Member

I have replaced this manually created package with the auto-generated melpa package in #65874.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: emacs 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

emacs-zmq binary is not installed
4 participants
@matthewbauer @nixos-discourse @fritz-k @adisbladis