Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

factorio: alpha 0.17.16 -> 0.17.32 #59902

Merged
merged 1 commit into from Apr 20, 2019
Merged

factorio: alpha 0.17.16 -> 0.17.32 #59902

merged 1 commit into from Apr 20, 2019

Conversation

bjpbakker
Copy link
Contributor

Motivation for this change

Game developers released a bunch of updates. Alpha version in current tree (0.17.16) is no longer available for download.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@joachifm joachifm merged commit 28e2f5a into NixOS:master Apr 20, 2019
@joachifm
Copy link
Contributor

Thank you. I suppose it makes sense to backport this. If so, please open a cherry-pick PR against the release branch.

@bjpbakker bjpbakker mentioned this pull request Apr 23, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bjpbakker @joachifm @GrahamcOfBorg