Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profanity: 0.5.1 -> 0.6.0 #59931

Merged
merged 4 commits into from Apr 22, 2019
Merged

profanity: 0.5.1 -> 0.6.0 #59931

merged 4 commits into from Apr 22, 2019

Conversation

eri451
Copy link
Contributor

@eri451 eri451 commented Apr 20, 2019 •
edited

Motivation for this change

I noticed the announcement of the profanity.im release version 0.6.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Apr 20, 2019

@GrahamcOfBorg build profanity

@c0bw3b
Copy link
Contributor

c0bw3b commented Apr 20, 2019

Build failure on Darwin. I guess the packages-osx patch is still needed?

@eri451
Copy link
Contributor Author

eri451 commented Apr 20, 2019

I am also unsure about the osx-patch. I asked on the irc what to do since I cannot build the package with the patch. I was told to leave it out.
Do I need a Mac to test this?

@c0bw3b
Copy link
Contributor

c0bw3b commented Apr 22, 2019

@GrahamcOfBorg build profanity

@c0bw3b
Copy link
Contributor

c0bw3b commented Apr 22, 2019 •
edited

@eri451 ideally yes, or ask around on IRC if a Darwin user is willing to do the test

I refreshed the Darwin patch for v0.6.0 sources so it is no longer a blocker.
The bot Darwin build wasn't complete only because it took too much time building gpgme

@c0bw3b c0bw3b merged commit caa4e9a into NixOS:master Apr 22, 2019
@eri451
Copy link
Contributor Author

eri451 commented Apr 25, 2019

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eri451 @c0bw3b @GrahamcOfBorg