Skip to content

cleanup redundant text in modules utilizing mkEnableOption #59911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

cleanup redundant text in modules utilizing mkEnableOption #59911

wants to merge 3 commits into from
+30 −29

Conversation

aanderse
Copy link
Member

Motivation for this change

Most of these looks horrible when searching through options.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@aanderse aanderse requested a review from infinisil as a code owner April 20, 2019 01:47
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Apr 20, 2019
rycee
rycee reviewed Apr 20, 2019
View reviewed changes
Copy link
Member

@rycee rycee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rycee @aanderse
Update nixos/modules/services/mail/offlineimap.nix
2e7dfda 
Co-Authored-By: aanderse <aaron@fosslib.net>
@rycee @aanderse
Update nixos/modules/services/admin/oxidized.nix
fdf15dc 
Co-Authored-By: aanderse <aaron@fosslib.net>
@rycee
Copy link
Member

rycee commented Apr 20, 2019

Thanks! Squashed and rebased to master in 4a11ce7.

@rycee rycee closed this Apr 20, 2019
taku0 pushed a commit to taku0/nixpkgs that referenced this pull request Apr 20, 2019
@aanderse @rycee
cleanup redundant text in modules utilizing mkEnableOption
4a11ce7 
Closes NixOS#59911
@aanderse aanderse deleted the mkEnableOption-cleanup branch April 20, 2019 13:08
@aanderse
Copy link
Member Author

Thanks for your careful review @rycee!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rycee rycee

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @rycee @GrahamcOfBorg