Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pythonPackages.sounddevice and upgrade 0.3.12 -> 0.3.13 #59913

Merged
merged 1 commit into from Apr 22, 2019
Merged

Fix pythonPackages.sounddevice and upgrade 0.3.12 -> 0.3.13 #59913

merged 1 commit into from Apr 22, 2019

Conversation

JohnAZoidberg
Copy link
Member

@JohnAZoidberg JohnAZoidberg commented Apr 20, 2019 •
edited

Motivation for this change

v0.3.12 was broken because the outdated patch didn't apply anymore.
I upgraded it to 0.3.13 and updated the patch.

Fixes #59909

Should probably be backported to 19.03.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JohnAZoidberg JohnAZoidberg mentioned this pull request Apr 20, 2019
Closed
@JohnAZoidberg JohnAZoidberg changed the title pythonPackages.sounddevice: 0.3.12 -> 0.3.13 Fix pythonPackages.sounddevice and upgrade 0.3.12 -> 0.3.13 Apr 21, 2019
@infinisil infinisil merged commit 45b0479 into NixOS:master Apr 22, 2019
@infinisil
Copy link
Member

Backported in 9d09f02

@JohnAZoidberg JohnAZoidberg deleted the sounddevice-0.3.13 branch May 6, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nix-shell -p pythonPackages.sounddevice: patching failed
3 participants
@JohnAZoidberg @infinisil @GrahamcOfBorg