Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libpst: Fix build #59912

Merged
merged 1 commit into from Apr 22, 2019
Merged

libpst: Fix build #59912

merged 1 commit into from Apr 22, 2019

Conversation

JohnAZoidberg
Copy link
Member

@JohnAZoidberg JohnAZoidberg commented Apr 20, 2019 •
edited

Disable Python integration because it can't find -lboost_python.
I can't seem to get it to find the library so I just decided to disable Python.

Build has been broken for almost a year: https://hydra.nixos.org/build/92480675

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JohnAZoidberg
libpst: Fix build
43d4132 
Disable Python integration because it can't find -lboost_python.
@joachifm
Copy link
Contributor

cc @tohl

@infinisil infinisil merged commit a9f5ea3 into NixOS:master Apr 22, 2019
@knedlsepp
Copy link
Member

knedlsepp commented Apr 23, 2019 •
edited

@JohnAZoidberg To enable boost-python it might suffice to use (boost.override { enablePython = true; }) in the buildinputs.

@JohnAZoidberg JohnAZoidberg deleted the libpst-boost-python branch April 23, 2019 16:39
@JohnAZoidberg
Copy link
Member Author

JohnAZoidberg commented Apr 23, 2019 •
edited

No, I tried that. Doesn't work...
Well yes that is how it's done but libpst still can't find it. We'll have to use that and also somehow make it find it.
Also there is pythonPackages.boost which does the same.

@JohnAZoidberg
Copy link
Member Author

Oh, should probably be backported to 19.03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JohnAZoidberg @joachifm @knedlsepp @infinisil @GrahamcOfBorg