Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome3.rygel: fix build #59824

Merged
merged 1 commit into from Apr 18, 2019
Merged

Conversation

worldofpeace
Copy link
Contributor

Fixes #59815

  • add patch for installation sysconfdir
  • disable api docs
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Fixes NixOS#59815

* add patch for installation sysconfdir
* disable api docs
@jtojnar
Copy link
Contributor

jtojnar commented Apr 18, 2019

Hmm, I must have forgotten to test Rygel once I started focusing on GUPnP. Otherwise, I do not understand how could I have missed this.

The issue with docs is that they still depend on old GUPnP:

error: Package `gupnp-1.0' not found in specified Vala API directories or GObject-Introspection GIR directories
error: Package `gupnp-1.0' not found in specified Vala API directories or GObject-Introspection GIR directories

Can you add the following patch https://gitlab.gnome.org/GNOME/rygel/issues/132#note_457444

and docbook_xsl and docbook_xml_dtd_43?

@worldofpeace
Copy link
Contributor Author

worldofpeace commented Apr 18, 2019

I've done those exact things manually and things at like
result-devdoc/share/gtk-doc/html/librygel-core were empty directories...

Saw all the same warnings too so I thought it wasn't worth it.

@lightbulbjim
Copy link
Contributor

I might be doing something wrong but I still get the same build failure with your branch.

@jtojnar
Copy link
Contributor

jtojnar commented Apr 18, 2019

I will take a look on complete fix later. This should be good to go for now.

@jtojnar
Copy link
Contributor

jtojnar commented Apr 18, 2019

Though maybe we need to link the etc file in rygel module.

@lightbulbjim
Copy link
Contributor

lightbulbjim commented Apr 18, 2019

Here is my failed build output: https://hastebin.com/inomojigis.sql

EDIT: actually never mind, I was also building my main channel version as well. Oops...

@worldofpeace
Copy link
Contributor Author

I will take a look on complete fix later. This should be good to go for now.

I've runtime tested and it does load /etc/rygel.conf.

Here is my failed build output: https://hastebin.com/inomojigis.sql

The command you used to build was incorrect

nix-build '<nixpkgs>' -A gnome3.rygel ~/repos/nixpkgs

should be

nix-build ~/repos/nixpkgs -A gnome3.rygel

By doing <nixpkgs> you just built this from nixpkgs of your current system.

@lightbulbjim
Copy link
Contributor

lightbulbjim commented Apr 18, 2019

The command you used to build was incorrect

Thanks for the pointer! That did the trick, and it's now building correctly.

I'm new to NixOS and sometimes these things aren't obvious :).

@worldofpeace
Copy link
Contributor Author

The command you used to build was incorrect

Thanks for the pointer! That did the trick, and it's now building correctly.

I'm new to NixOS and sometimes these things aren't obvious :).

I understand. Thanks for testing ❇️

@worldofpeace worldofpeace merged commit 93d1127 into NixOS:master Apr 18, 2019
@worldofpeace worldofpeace deleted the rygel-fix-build branch April 18, 2019 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rygel fails to build
4 participants