Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parity: 2.3 -> 2.4 #59826

Merged
merged 2 commits into from Apr 23, 2019
Merged

parity: 2.3 -> 2.4 #59826

merged 2 commits into from Apr 23, 2019

Conversation

akru
Copy link
Contributor

@akru akru commented Apr 18, 2019 •
edited

Motivation for this change

Upgrade to latest version of parity-ethereum.

WARNING: #57017 should be merge before this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

The other PR was merged, can you rebase this on top of it so ofborg can build the package?

@akru
Copy link
Contributor Author

akru commented Apr 23, 2019

@GrahamcOfBorg build parity parity-beta

c0bw3b
c0bw3b approved these changes Apr 23, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local nix-review on NixOS is successful.

$ ./results/altcoins.parity/bin/parity --version
Parity Ethereum
  version Parity-Ethereum/v2.4.5-unstable/x86_64-linux-gnu/rustc1.34.0

$ ./results/altcoins.parity-beta/bin/parity --version
Parity Ethereum
  version Parity-Ethereum/v2.5.0-unstable/x86_64-linux-gnu/rustc1.34.0

@infinisil infinisil merged commit 61e2c7b into NixOS:master Apr 23, 2019
@akru akru deleted the parity branch April 23, 2019 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@akru @infinisil @c0bw3b @GrahamcOfBorg