folly: support macOS #59846

strager · 2019-04-18T16:39:07Z

Motivation for this change

Enable building the folly library on macOS (Darwin).

Things done

veprbl · 2019-04-27T19:20:18Z

The patches to disable tests might require more work to maintain. Do you think we could do it cleaner with just substituteInPlace?

strager · 2019-04-29T04:34:08Z

@veprbl, I uploaded a new version which uses substituteInPlace. I don't have experience maintaining packages to know which is better. Let me know what you think about the substituteInPlace version compared to the old version (strager@700f99d).

veprbl

LGTM

veprbl · 2019-05-02T16:46:49Z

@GrahamcOfBorg build folly

veprbl · 2019-05-02T18:15:39Z

Fails to build

strager · 2019-05-03T03:40:28Z

Yeah, f75c68c introduced problems. I'll rebase and fix them.

Make it easier to catch possible misconfiguration and regressions for the folly package by running folly's test suite.

* operator new + align() is supported only since macOS 10.13. Disable uses of align() to support macOS 10.11 and 10.12. This affects performance but should not affect correctness. * Clang 5 fails to emit typeinfo symbols for some folly::dynamic classes. Work around this bug by compiling folly with a newer version of Clang. * Clang fails to compile some sketchy code in Boost.Atomic. Boost.Atomic is a dependency of folly. Backport the fix for this bug to Boost 1.67.

veprbl

Since we just had a breakage due to the patches, perhaps we could remove some of them.

veprbl · 2019-05-07T15:14:16Z

pkgs/development/libraries/folly/darwin-printf-test.patch

+   // Errors attempting to format the message should not throw
+   FB_LOGC(footest1234, ERR, "width overflow: %999999999999999999999d", 5);
+   ASSERT_EQ(1, messages.size());
+#if 0


Should we just disable PrintfTest?

veprbl · 2019-05-07T15:21:12Z

pkgs/development/libraries/folly/nixos-test-paths.patch

+@@ -50,10 +50,10 @@ TEST(Simple, Path) {
+ }
+
+ TEST(Simple, CanonicalizeParent) {


Not sure if this is sandbox-safe. Should we just disable this test?

veprbl · 2019-05-07T15:31:49Z

pkgs/development/libraries/folly/default.nix

-stdenv.mkDerivation rec {
+let
+  disableTests = import ./disable-tests.nix { inherit (stdenv) lib; };
+  optionals = stdenv.lib.optionals;


Suggested change

optionals = stdenv.lib.optionals;

inherit (stdenv.lib) optionals;

veprbl · 2019-05-07T17:19:56Z

pkgs/development/libraries/folly/macos-10.11.patch

@@ -0,0 +1,88 @@
+--- a/folly/IndexedMemPool.h


I can build folly without this patch. Is this for uses in the code built with clang 5?

veprbl · 2019-05-07T17:48:52Z

pkgs/top-level/all-packages.nix

-  folly = callPackage ../development/libraries/folly { };
+  folly = callPackage ../development/libraries/folly {
+    # Clang 5 miscompiles folly. Build with a newer compiler on Darwin.
+    stdenv = if stdenv.isDarwin then llvmPackages_7.stdenv else stdenv;


Not needed anymore since ae1e940 has just landed on master #60491

veprbl · 2019-06-07T14:59:41Z

macOS support was merged as a part of #62330

veprbl · 2019-12-27T21:21:51Z

@strager Are you still interested in contributing the tests?

strager · 2019-12-31T06:00:38Z

@strager Are you still interested in contributing the tests?

I have no plans to work on this PR or on folly. You can take over my work if you want.

stale · 2020-06-28T06:58:55Z

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

Search for maintainers and people that previously touched the related code and @ mention them in a comment.
Ask on the NixOS Discourse.
Ask on the #nixos channel on irc.freenode.net.

SuperSandro2000 · 2020-11-27T23:58:06Z

@strager please resolve the merge conflicts.

prusnak · 2020-11-28T08:43:18Z

Closing. macOS support was added #62330 and @Stragger expressed he does not want to work on the tests: #59846 (comment)

GrahamcOfBorg added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) labels Apr 18, 2019

GrahamcOfBorg requested a review from abbradar April 18, 2019 16:48

GrahamcOfBorg added 10.rebuild-darwin: 101-500 10.rebuild-linux: 1-10 labels Apr 18, 2019

strager marked this pull request as ready for review April 20, 2019 07:24

strager force-pushed the folly-macos branch from 700f99d to b3fdc2f Compare April 29, 2019 04:33

strager mentioned this pull request Apr 29, 2019

folly: build and run tests #57220

Closed

10 tasks

ofborg bot added the 6.topic: nixos label Apr 29, 2019

veprbl approved these changes Apr 29, 2019

View reviewed changes

strager added 2 commits May 2, 2019 20:40

folly: build and run tests

0f0600f

Make it easier to catch possible misconfiguration and regressions for the folly package by running folly's test suite.

strager force-pushed the folly-macos branch from b3fdc2f to dda658d Compare May 3, 2019 05:41

veprbl reviewed May 7, 2019

View reviewed changes

veprbl added the 2.status: merge conflict label May 7, 2019

matthewbauer approved these changes Jun 11, 2019

View reviewed changes

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 28, 2020

ryantm added 2.status: merge conflict and removed 2.status: merge conflict labels Oct 3, 2020

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020

acairncross mentioned this pull request Oct 13, 2020

folly: 2019.11.11.00 -> 2020.09.28.00, fix build #99133

Merged

10 tasks

prusnak closed this Nov 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

folly: support macOS #59846

folly: support macOS #59846

strager commented Apr 18, 2019 •

edited

veprbl commented Apr 27, 2019

strager commented Apr 29, 2019

veprbl left a comment

veprbl commented May 2, 2019

veprbl commented May 2, 2019

strager commented May 3, 2019

veprbl left a comment

veprbl May 7, 2019

veprbl May 7, 2019

veprbl May 7, 2019

veprbl May 7, 2019 •

edited

veprbl May 7, 2019

veprbl commented Jun 7, 2019

veprbl commented Dec 27, 2019

strager commented Dec 31, 2019

stale bot commented Jun 28, 2020

SuperSandro2000 commented Nov 27, 2020

prusnak commented Nov 28, 2020

	optionals = stdenv.lib.optionals;
	inherit (stdenv.lib) optionals;

folly: support macOS #59846

folly: support macOS #59846

Conversation

strager commented Apr 18, 2019 • edited

Motivation for this change

Things done

veprbl commented Apr 27, 2019

strager commented Apr 29, 2019

veprbl left a comment

Choose a reason for hiding this comment

veprbl commented May 2, 2019

veprbl commented May 2, 2019

strager commented May 3, 2019

veprbl left a comment

Choose a reason for hiding this comment

veprbl May 7, 2019

Choose a reason for hiding this comment

veprbl May 7, 2019

Choose a reason for hiding this comment

veprbl May 7, 2019

Choose a reason for hiding this comment

veprbl May 7, 2019 • edited

Choose a reason for hiding this comment

veprbl May 7, 2019

Choose a reason for hiding this comment

veprbl commented Jun 7, 2019

veprbl commented Dec 27, 2019

strager commented Dec 31, 2019

stale bot commented Jun 28, 2020

SuperSandro2000 commented Nov 27, 2020

prusnak commented Nov 28, 2020

strager commented Apr 18, 2019 •

edited

veprbl May 7, 2019 •

edited