build: add DSL for defining platform resources. #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
+ Coverage 85.73% 85.91% +0.17%
==========================================
Files 27 28 +1
Lines 4010 4060 +50
Branches 803 817 +14
==========================================
+ Hits 3438 3488 +50
Misses 479 479
Partials 93 93
Continue to review full report at Codecov.
|
whitequark
suggested changes
Apr 18, 2019
There was a problem hiding this comment.
See review comments above.
Also, please rename the entire module such that it becomes nmigen.build.dsl.
Also, please write tests for Pins and DiffPairs to verify that these APIs work correctly. I think I will ask for more changes to Subsignal so you don't need to write tests for that for now.
whitequark
suggested changes
Apr 20, 2019
whitequark
approved these changes
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.