New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
seasocks: init at 1.4.2 #59965
seasocks: init at 1.4.2 #59965
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution since it's your 1st PR here :)
Also your commit message should rather be: |
Everything should be updated @c0bw3b :) |
@GrahamcOfBorg build seasocks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds are successful :)
Motivation for this change
Needed seasocks for a project, so i made a nix package for it!
Things done
Added
pkgs/development/libraries/seasocks/default.nix
Added
seasocks = callPacakge ../development/libraries/seasocks {};
Only tested in nix shell. But works as intended in development environment, correctly setting
$NIX_LDFLAGS
and$NIX_CFLAGS_COMPILE
to include the needed library and header files.Tested using sandboxing (nix.useSandbox on NixOS, or option
sandbox
innix.conf
on non-NixOS)Built on platform(s)
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using
nix-shell -p nix-review --run "nix-review wip"
Tested execution of all binary files (usually in
./result/bin/
)Determined the impact on package closure size (by running
nix path-info -S
before and after)Assured whether relevant documentation is up to date
Fits CONTRIBUTING.md.