Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffsend: 0.2.42 -> 0.2.45 #59918

Merged
merged 1 commit into from Apr 22, 2019
Merged

ffsend: 0.2.42 -> 0.2.45 #59918

merged 1 commit into from Apr 22, 2019

Conversation

lilyball
Copy link
Member

@lilyball lilyball commented Apr 20, 2019 •
edited

Motivation for this change

https://github.com/timvisee/ffsend/releases/tag/v0.2.45

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lilyball lilyball marked this pull request as ready for review April 22, 2019 04:31
c0bw3b
c0bw3b approved these changes Apr 22, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local nix-review is ok

@c0bw3b c0bw3b merged commit 78f3e9f into NixOS:master Apr 22, 2019
@lilyball lilyball deleted the ffsend branch April 23, 2019 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lilyball @c0bw3b @GrahamcOfBorg